search

Ekeany / Boruta-Shap

A Tree based feature selection tool which combines both the Boruta feature selection algorithm with shapley values.
MIT License
559 stars 86 forks source link

[BUG] importance_measure has a default value that causes an error in the fit() method #125

Open treyworl opened 7 months ago

treyworl commented 7 months ago

Describe the bug

The default value of the BorutaShap class's importance_measure parameter is 'Shap' (uppercase "S") and causes the fit() method to fail. It hsould be lowercase "s" in 'shap'

To Reproduce

Versions: python 3.8.6 BorutaShap==1.0.17

from BorutaShap import BorutaShap, load_data

X, y = load_data(data_type='regression')
Feature_Selector = BorutaShap()
Feature_Selector.fit(X, y)

Expected behavior

Either importance_measure should have a default that works (does not cause an error) or have no default and require the user to specify.

Screenshots

image

Additional context

Add any other context about the problem here.