Ekeany / Boruta-Shap

A Tree based feature selection tool which combines both the Boruta feature selection algorithm with shapley values.

MIT License

559 stars 86 forks source link

BorutaShap throws error if there are missing values in the data even if the model used is lightgbm [BUG] #44

Closed Nitinsiwach closed 3 years ago

Nitinsiwach commented 3 years ago

Describe the bug

Currently, BorutaShap throws error if there are missing values in the data even if the model used is lightgbm. The reason is that the code checks for string 'lgbm' instead of 'lightgbm' as a marker to see if the model used is 'lightgbm'

LIne 179 in BorutaShap.py models_to_check = ('xgb', 'catboost', 'lgbm') should be models_to_check = ('xgb', 'catboost', 'lgbm', 'lightgbm') Since, model=LGBMClassifier() print(type(model)) #lightgbm.sklearn.LGBMClassifier

Ekeany commented 3 years ago

Hi,

Thanks for spotting this bug have updated the code as per your solution.

Ekeany commented 3 years ago

merged your pull request thanks again