search

Ekeany / Boruta-Shap

A Tree based feature selection tool which combines both the Boruta feature selection algorithm with shapley values.
MIT License
559 stars 86 forks source link

[BUG] sample_fraction parameter is not implemented #84

Open BlackArbsCEO opened 2 years ago

BlackArbsCEO commented 2 years ago

Describe the bug

The documents describe a the function parameters for the fit argument and include a sample_fraction parameter that's used if sample=True however that parameter is not actually implemented in the function.

To Reproduce

Steps to reproduce the behavior:

  1. Go to boruta.py
  2. Look at the parameters that are implemented vs the docs and you will see that it is missing

Expected behavior

sample_fraction to sample some portion of the data to enhance speed.

Additional context

Add any other context about the problem here.

EXJUSTICE commented 1 year ago

I can confirm this, having the same issue