search

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.
MIT License
1.7k stars 202 forks source link

Adding support for iPhone 12 devices and previously missing ones #106

Closed ozgur closed 3 years ago

ozgur commented 4 years ago

Thanks to @felixbuenemann, this PR covers his changes as well as new types of iPhone 12 devices that have been recently introduced.

Thus, it fixes the following issues: https://github.com/Ekhoo/Device/pull/90, https://github.com/Ekhoo/Device/issues/94, https://github.com/Ekhoo/Device/issues/101, https://github.com/Ekhoo/Device/issues/105.

EdSancha commented 3 years ago

It seems that the new iPad Air and iPad Pro versions are missing here too, is it better to do it in a new PR? I could help with that.

ozgur commented 3 years ago

@EdSancha you can take my and @felixbuenemann 's commits and create a new PR containing them, just like what I've done with his commit.

EdSancha commented 3 years ago

Once I downloaded it I realized those devices were also included! Thanks and hopefully @Ekhoo will merge this soon. Thanks a lot for your contribution

florianpreknya commented 3 years ago

Thanks for your contribution @felixbuenemann! I'm waiting for this merge, too.

subliminaldev commented 3 years ago

use this pod 'Device', :git => 'https://github.com/ozgur/Device.git'

ozgur commented 3 years ago

@Ekhoo any update on getting this merged?

teameh commented 3 years ago

@Ekhoo anything we can do to help getting this released?

Ekhoo commented 3 years ago

Sorry guys, I'll merge it today

teameh commented 3 years ago

Awesome! No worries. Would you be so kind to also release a new version 😊 ?

johndpope commented 3 years ago

pod 'Device', :git => 'https://github.com/Ekhoo/Device.git', :commit =>'f2f796b86201cd96271417b99dfd41eb338db395'