Carthage Support - Githubissues

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.

MIT License

1.7k stars 202 forks source link

Closed reallyseth closed 8 years ago

reallyseth commented 8 years ago

I added a framework target and shared the scheme. Tested on my forked repo with Carthage and it worked great! This fixes #10 and #8

chuganzy commented 8 years ago

Hi! Though I created a same PR (#11) 2 days ago, is there any problem with it? I just want to know if there is.

Thanks.

reallyseth commented 8 years ago

Oh, I hadn't seen it. Sorry about that, my fault! I'm happy to cancel mine. Hopefully the owner merges yours in soon.

chuganzy commented 8 years ago

Never mind👍I'm relieved to hear that.

Ekhoo commented 8 years ago

Hello, thank you very much for your PR but it's fixed in #11. I will build a new release today. Thank you :)

Ekhoo commented 8 years ago

I close

Ekhoo commented 8 years ago