search

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.
MIT License
1.7k stars 202 forks source link

Podspec deployment target needs to updated #123

Closed glm4 closed 1 year ago

glm4 commented 1 year ago

Currently, the podspec specify the deployment target to iOS 8.0.

For other Cocoapods libraries, if you have Device as a dependency pod, your library will not lint correctly your podspec using Xcode 14.3 and up. Please refer to this issue on Cocoapods. So far there is no way to specify custom deployment targets for dependencies with the Podspec syntax, so this should be resolved by each pod podspec.

This is not a problem if you install the dependency via SPM or directly into your project via cocoapods

kishorepran commented 1 year ago

@glm4 : will updating the pod spec to 9.0 suffice...? If yes I will raise a pr > add you for review> release a minor version. let me know thanks.

glm4 commented 1 year ago

Hi @kishorepran! Unfortunately no 😢 Xcode 14.3 ony supports from iOS 11 and up. It is a limitation for Device doing this update?

kishorepran commented 1 year ago

hi @glm4 . I am not sure. Will need to check. by default I want to keep the min version possible. Let me give this a try tomorrow.

ozgur commented 1 year ago

same issue for carthage as well:

/Users/ozgur/Developer/TestApp/Carthage/Checkouts/Device/Device.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'Device' from project 'Device') ** ARCHIVE FAILED **

kishorepran commented 1 year ago

Guys can you please review my pr will merge and release version ASAP @glm4: sorry for delay @ozgur : Is it possible for you to check with my branch for Carthage. thanks for your support.

Edit: 🎉 Congrats 🚀 Device (3.5.0) successfully published 📅 August 1st, 13:38 🌎 https://cocoapods.org/pods/Device 👍 Tell your friends!

glm4 commented 1 year ago

@kishorepran LGTM