👔 Adding hasHomeButton check

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.

MIT License

1.7k stars 202 forks source link

👔 Adding hasHomeButton check #135

Closed wo-ist-henry closed 6 days ago

wo-ist-henry commented 3 months ago

Adding the check if the current iPhone has a HomeButton or not

kishorepran commented 1 month ago

@mlch911 : I am assuming you are using this service regularly can you please review if this adds value. most of the devices mentioned below are out of market. what do you think. there is no harm though.

mlch911 commented 1 month ago

@mlch911 : I am assuming you are using this service regularly can you please review if this adds value. most of the devices mentioned below are out of market. what do you think. there is no harm though.

I don't think this method is too necessary, homeButton has been gone for a long time. In fact, you can use safeAreaInset.bottom == 0 to check if there is a home button, and don't have to write the exexact models.

kishorepran commented 6 days ago

Closing the pull request as per my understanding and feedback from community folks. @wo-ist-henry : please if you + other community members have a use case yet. if yes. will reconsider this.