updated iphone and ipad models, added the '18 products, made compatible with Swift 4.2, updated readme and added some code completion comments

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.

MIT License

1.7k stars 202 forks source link

updated iphone and ipad models, added the '18 products, made compatible with Swift 4.2, updated readme and added some code completion comments #69

Closed nikans closed 6 years ago

nikans commented 6 years ago

also changed unnecessary "static open" for "static public" to keep the checker happy

nikans commented 6 years ago

So, list of fixes:

added new iphones and ipads, screen sizes and all; added some missed old model names, too
swift 4.2 Xcode 10 compatibility fixes
updated readme

nikans commented 6 years ago

added useful comments for screen sizes — because it's now a bit hard to navigate all those 6.1 vs 6.5 etc diagonals

attheodo commented 6 years ago

@Ekhoo any chance this or #68 or #67 get merged soon?

Ekhoo commented 6 years ago

Well done thx 👍

Ekhoo commented 6 years ago

I cannot release a new cocoapod version right now because I have an error with the mac target during the pod trunk push and I don't really have the time to fix it :(