search

Ekhoo / Device

Light weight tool for detecting the current device and screen size written in swift.
MIT License
1.7k stars 202 forks source link

Properties, lazy computation and system version #9

Closed delba closed 7 years ago

delba commented 8 years ago

Hey, thanks for the lib!

This PR introduces some breaking changes and I would love to discuss them.

The updated version of the README is here

Feedback welcomed :smiley:

zsk425 commented 8 years ago

@delba I like the comparison operations of Size:thumbsup:

But the scheme you created is not correct, you should create a framework target first, and then create a new shared scheme with the framework target.

delba commented 8 years ago

@zsk425 Indeed I didn't realize that the lib was created from an application... Thanks for catching this!

I removed this commit as the new framework target should be at @Ekhoo's name.

steffex commented 8 years ago

I don't like the emoji added to Device. It's a nice gimmick, but it's all but adding functionality to the code.

delba commented 8 years ago

@steffex It's used to give different names to the class (📱Device) and the instance (Device). Also it's not supposed to be used directly.

I don't like the naming though. Any suggestions?