Closed delba closed 7 years ago
@delba I like the comparison operations of Size:thumbsup:
But the scheme you created is not correct, you should create a framework target first, and then create a new shared scheme with the framework target.
@zsk425 Indeed I didn't realize that the lib was created from an application... Thanks for catching this!
I removed this commit as the new framework target should be at @Ekhoo's name.
I don't like the emoji added to Device. It's a nice gimmick, but it's all but adding functionality to the code.
@steffex It's used to give different names to the class (📱Device) and the instance (Device). Also it's not supposed to be used directly.
I don't like the naming though. Any suggestions?
Hey, thanks for the lib!
This PR introduces some breaking changes and I would love to discuss them.
versionCode
andscreenHeight
are lazily evaluateddevice
,type
andsize
are now propertiesSize
conforms to the Comparable protocolDevice.systemVersion
The updated version of the README is here
Feedback welcomed :smiley: