Ekito / koin-samples

KOIN - a concise and pragmatic dependency injection framework for Kotlin -- #Samples
Apache License 2.0
214 stars 80 forks source link

Use shared ViewModel in Fragments #2

Open petoalbert opened 6 years ago

petoalbert commented 6 years ago

The WeatherApp sample does not work correctly, because the Fragment uses a different ViewModel than the Activity. It seems like it was forgotten to be updated after 0.9.1. Since the sampleapp-arch was also created before updating to 0.9.1, I guess it was also meant to be used with a shared ViewModel.

dwkim-sugarhill commented 6 years ago

👍 we need this PR