search

Ekryd / sortpom

Maven plugin that helps the user sort pom.xml.
https://github.com/Ekryd/sortpom/wiki/
BSD 3-Clause "New" or "Revised" License
336 stars 181 forks source link

LATEST using in pom is deprecated and will be removed from maven 4 #345

Closed hazendaz closed 1 year ago

hazendaz commented 1 year ago

I see you changed your latest ITs to use LATEST all over, that is deprecated for long time. It will see you end up with future problems. If you were trying to reduce possibly what bots suggest on updates, add properties to your root pom to control those and keep just the one per the what appears many usage of same so bot at worst will only raise the single pull requests.

Ekryd commented 1 year ago

Hi! Thanks for the concern. The problem is that the bots updated the pom file, but not the expected pom file in the integration tests, causing a lot of manual correcting overhead for me. I also experimented with creating separate directories for expected pom and such, but no success. I’m aware that LATEST is deprecated, but this solution works best for me right now. 😃

Ekryd commented 1 year ago

A public release of Maven 4 might change everything though 🤞

hazendaz commented 1 year ago

Understood, no problem then for now.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Björn Ekryd @.> Sent: Friday, July 28, 2023 2:37:49 PM To: Ekryd/sortpom @.> Cc: Jeremy Landis @.>; Author @.> Subject: Re: [Ekryd/sortpom] LATEST using in pom is deprecated and will be removed from maven 4 (Issue #345)

A public release of Maven 4 might change everything though 🤞

— Reply to this email directly, view it on GitHubhttps://github.com/Ekryd/sortpom/issues/345#issuecomment-1656165523, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI3F2SMEMXSXSBZBFKLXSQBH3ANCNFSM6AAAAAA23XGT3I. You are receiving this because you authored the thread.Message ID: @.***>

Ekryd commented 1 year ago

Have you tried out Maven 4 with SortPom yourself? Are there are any known problems

hazendaz commented 1 year ago

Haven't tried with sortpom. Have with others. Maven 4 definitely is not ready for prime time. I have it running in parallel on some repos in GHA and there are oddities like enforcer plugin with jdk 17 doesn't seem to work correctly which ends up blocking my other plugins usage. My guess we won't see GA until 2024.

Given all the micro issues popping on 3.9.x, they have a ways to go.

You may want to look into renovate for lib updates. It just works better.

I'm eventually going to make sure to run 4 alphas against all plugins I support. I know code wise we all have a lot to fix up and there isn't much documentation on how to fix some issues. Even maven hasn't complied with all their changes either.

I did sign up to their dev mailing list a while ago which does help understand where they are trying to go.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Björn Ekryd @.> Sent: Friday, July 28, 2023 4:32:19 PM To: Ekryd/sortpom @.> Cc: Jeremy Landis @.>; Author @.> Subject: Re: [Ekryd/sortpom] LATEST using in pom is deprecated and will be removed from maven 4 (Issue #345)

Have you tried out Maven 4 with SortPom yourself? Are there are any known problems

— Reply to this email directly, view it on GitHubhttps://github.com/Ekryd/sortpom/issues/345#issuecomment-1656301048, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI5VSDOX7E6R5VIQVBLXSQOVHANCNFSM6AAAAAA23XGT3I. You are receiving this because you authored the thread.Message ID: @.***>

Ekryd commented 1 year ago

Renovate sounds interesting. I will have to look into that, especially since I have a local GitLab instance that cannot run dependabot. And if it is a bit more configurable, then it can solve my IT tests as well. Interesting that you have repos with Maven 4 running in parallel, do you have a link where I can see it setup? Great tips!

hazendaz commented 1 year ago

Here is an example of where I have maven 4 running on github actions -> https://github.com/spotbugs/spotbugs-maven-plugin/blob/spotbugs/.github/workflows/it-maven-4.0.0.yaml

Ekryd commented 1 year ago

Thanks for all the information! Tried out Renovate and it work much better than Dependabot. I was able to get rid of all LATESTS as Renovate handles my integration tests out of the box. I will also try to setup a job for Maven 4, but I will do that in a separate Jira. Closing this issue now and if you see anything else that can be improved, your input is always welcome