search

Ekumen-OS / Noah-bot-simulation

BSD 3-Clause "New" or "Revised" License
7 stars 2 forks source link

Launch files reorganization #13

Open JCarosella opened 2 years ago

JCarosella commented 2 years ago

Closes #12

francocipollone commented 2 years ago

I would still call it noah_gazebo instead of noah_simulation. Why? Because:

  1. In general it is how I've seen it out there: e.g.: https://github.com/ros-mobile-robots/diffbot
  2. It is scalable: Let's say that we want to create an ignition simulation, we simply add a noah_ignition folder.
JCarosella commented 2 years ago

I would still call it noah_gazebo instead of noah_simulation. Why? Because:

  1. In general it is how I've seen it out there: e.g.: https://github.com/ros-mobile-robots/diffbot
  2. It is scalable: Let's say that we want to create an ignition simulation, we simply add a noah_ignition folder.

Well, that makes sense. In my head instead of adding another package I was thinking in adding another branch, but if the simulators both use ROS it makes sense to just add another package here.

I'll roll back the change, which should remove a ton of diffs. Let's hold the review until that is done

JCarosella commented 2 years ago

@francocipollone Rolled back to noah_gazebo package name.Ready for review again.

I also removed the pictures of people from the small_house world