Closed ericmjl closed 3 years ago
Merging #97 (1ea5cc4) into master (42f1217) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 12 12
Lines 524 524
=======================================
Hits 513 513
Misses 11 11
Flag | Coverage Δ | |
---|---|---|
python | 97.90% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 42f1217...1ea5cc4. Read the comment docs.
Yo! What parts are still missing here? Docs, anything else? I could give implementing the docs a try to gain some familiarity with github actions as well, unless you have it already in the works?
I haven't attempted docs just yet -- please give it a shot! I'd say that the docs should run parallel to the tests, so if you sort of follow the pattern for the fast/slow tests section in the same YAML file, you'll be set.
@ericmjl I'm not sure whether the mkdocs deploy action can handle all the extra dependencies we need to build our docs. If we need to install our env first, do you know if we can use the build-environment
step from continous-integration.yml
directly in deploy-docs.yml
, or do we need to copy it over?
Codecov-action behaves weird with coverage. Gonna change back to the old way since that worked fine.
@ericmjl I'm not sure whether the mkdocs deploy action can handle all the extra dependencies we need to build our docs. If we need to install our env first, do you know if we can use the
build-environment
step fromcontinous-integration.yml
directly indeploy-docs.yml
, or do we need to copy it over?
I think those build steps will have to be copied over. There's a choice to be made on how to organize the YAML files, but I think organizing by "task to be done", rather than "on what trigger", makes the most sense.
Agree. I'll go ahead and copy them in.
Merging!
PR Description
This PR introduces GitHub Actions as the CI pipeline for jax-unirep, replacing Travis CI.
Closes #91.
Left todo:
Checklist
General
<your_username>
:<feature-branch_name>
), not<your_username>
:master
.CHANGELOG.md
file at the top.README
.Code checks
tests
directory.environment.yml
.make test
in a console in the top level directory to make sure all the tests pass.make format
in a console in the top level directory to make the code comply with the formatting standards.