ElCeejo / animalia

Basic Fauna for Minetest Game
MIT License
14 stars 37 forks source link

horse.on_rightclick does not seem to ever attempt to tame the horse #92

Open jfanjoy opened 7 months ago

jfanjoy commented 7 months ago

It seems like taming is defined in the api as an argument to feeding which is false in mobs/horse.lua:on_rightclick. It would also seem that only an owner can interact with horses to place a saddle or mount them so there appears to be no way to tame them. Please let me know if I am missing something, but as far as I can tell feeding a horse will lead to breeding mode (hearts) but not taming/ownership (green).

I see nametags exist, but there is no craft recipe and it looks like name tags are handled after determining whether or not the horse has an owner. I am no. proficient in lua so I may be completely wrong, but this is the behavior I am seeing when I try to tame a horse. If I revert the change made in this commit I am able to attempt to mount the horse with nothing equipped. They still kick me off immediately but an attempt is made while with the line 374 as it is today they basically seem to ignore the interaction.

somechris commented 1 week ago

The tame parameter to animalia.feed only states whether or not the animal can be tamed by feeding. Horses cannot be tamed by feeding, so it the is set to false for horses.

To tame a horse, ride it without a saddle (i.e.: simply right-click on it when not having anything in hands) and (important!) look in the direction of the horse's head, while riding. Once ridden long enough, it'll drop you off again. Then you'll see