search

ElDewrito / ElDorito

A Halo Online modification
725 stars 142 forks source link

Remove hard-coded tilde input bind #485

Open locosux opened 6 years ago

locosux commented 6 years ago

https://github.com/ElDewrito/ElDorito/blob/6098037ed686159e6cf11e0fcb56806a887db1b0/ElDorito/Source/Web/Ui/WebConsole.cpp#L58

A configuration override could be added to disable the usage of tilde (or f1) to open the console. Also seems a bit silly to have two (unbindable) keys dedicated to opening the console.

It's a common voip push-to-talk hot-key. It looks like a simple change, I just don't have a dev environment setup to test it out.

HomerGaidarski commented 6 years ago

yes i definitely want this too, i have a dev environment setup, gonna take longer to add to the keybinding menu a place for setting the console key, so i'm just gonna remove the tilde bind to the console.

HomerGaidarski commented 6 years ago

unfortunately removing GetKeyTicks(eKeyCodeTilde, eInputTypeUi) == 1 from that line only prevents the console from popping up while you're playing the game, but if you try to set the tilde key in the keyboard edit menu the console still pops up, so this fixes your issue if you primarily use discord client for communication but not for common voice chat in halo

locosux commented 6 years ago

It looks like the following two lines also handle showing the console: Title screen: https://github.com/ElDewrito/ElDorito/blob/4db61d45db75eecae8058cfb5018984660d83d9f/dist/mods/ui/web/screens/title/title.js#L34 Loading screen: https://github.com/ElDewrito/ElDorito/blob/4db61d45db75eecae8058cfb5018984660d83d9f/dist/mods/ui/web/screens/loading/loading.js#L11 And for closing: https://github.com/ElDewrito/ElDorito/blob/4db61d45db75eecae8058cfb5018984660d83d9f/dist/mods/ui/web/screens/console/console.js#L735

Tilde is keyboard code 192 in javascript. Side note: any idea what 223 is?