ElMassimo / iles

๐Ÿ The joyful site generator
https://iles.pages.dev
MIT License
1.08k stars 31 forks source link

fix: explicitly export types from composable #116

Closed johannschopplich closed 2 years ago

johannschopplich commented 2 years ago

Description ๐Ÿ“–

This pull request fixes the type checking in my รฎles project.

Background ๐Ÿ“œ

This was happening because of the following TS error:

node_modules/.pnpm/iles@0.7.37/node_modules/iles/dist/client/index.ts:11:26 - error TS1205: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.

11 export { useVueRenderer, VueRenderable } from './app/composables/vueRenderer'
                            ~~~~~~~~~~~~~

Found 1 error in node_modules/.pnpm/iles@0.7.37/node_modules/iles/dist/client/index.ts:11

The Fix ๐Ÿ”จ

By adding an explicit type export, the type checking should be fine.

Screenshots ๐Ÿ“ท

None available.

nx-cloud[bot] commented 2 years ago

Nx Cloud Report

CI is running for commit 415d917c5b965f0825ece772817ebb2ef1eeaa3f.

๐Ÿ“‚ Click to track the progress, see the status, the terminal output, and the build insights.


Sent with ๐Ÿ’Œ from NxCloud.

ElMassimo commented 2 years ago

Thanks Johann! ๐Ÿ˜ƒ @johannschopplich

Released this fix in iles@0.7.38.

johannschopplich commented 2 years ago

Thank you for รฎles. Itโ€™s my favourite SSG and a great source of inspiration for semantic code style. ๐Ÿ˜Š