search

ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.07k stars 31 forks source link

fix: cannot detect kebab-case components #152

Closed ElMassimo closed 2 years ago

ElMassimo commented 2 years ago

Description 📖

This pull request fixes a bug where kebab-case usages of a component with a hydration directive were not being detected.

It also upgrades to the latest version of unplugin-vue-components, to ensure that any bug fixes or new resolvers are available for îles apps.

Background 📜

Internally, we are using unplugin-vue-components to detect components.

The findComponent API was added in https://github.com/antfu/unplugin-vue-components/pull/329, but it expects a PascalCase string as the first parameter.

The Fix 🔨

Applying pascalCase to the tag before calling findComponent fixes this issue, and allows components to be detected regardless of which convention is used.

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 21cbbbae7d870621ea727db6efcca18c05d47ffc. You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

cloudflare-pages[bot] commented 2 years ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 21cbbba
Status: ✅  Deploy successful!
Preview URL: https://da21ec80.iles.pages.dev
Branch Preview URL: https://fix-kebab-components.iles.pages.dev

View logs