Closed maoberlehner closed 2 years ago
CI is running for commit d327020615fdf27f7237c54def99f0d638ad5b89.
📂 Click to track the progress, see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud.
I have no idea why but I was not able to get https://github.com/ElMassimo/iles/compare/fix/create-ssr-app to run on my machine. Got a ton of TypeScript errors. And even ignoring all the TypeScript errors, the build failed.
With this branch I'm able to:
pnpm run build:all
without errors.pnpm docs:now
without errors.Looks great!
Seems that I forgot about upgrading the main client app to SSR app as well, which explains the errors I was seeing during dev.
Thanks @maoberlehner! 😃
Description 📖
This pull request enables more efficient hydration by using
createSSRApp
. See: https://vuejs.org/guide/scaling-up/ssr.html#client-hydrationBackground 📜
createSSRApp
is optimized for hydration of SSR-rendered HTML. This is more efficient because if the HTML stays the same, only event listeners need to be applied but the DOM is left untouched.The Fix 🔨
By using
createSSRApp
we get all the benefits of efficient hydration.