ElMassimo / iles

🏝 The joyful site generator

https://iles.pages.dev

MIT License

1.07k stars 31 forks source link

fix: windows incompatibility when rendering site (close #161) #163

Closed ElMassimo closed 2 years ago

ElMassimo commented 2 years ago

Description 📖

This pull request fixes the Windows incompatibility issue reported in #161.

Background 📜

This was happening because unlike require, the dynamic import in node does not handle forward slashes in Windows.

The Fix 🔨

By prepending the path with the file:// protocol, it interprets the path correctly.

Thanks to @ohuu for providing detailed information and proposing a solution ❤️

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit d6bc82407ad2360072cfda797ea5911e39ae13f4. You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

cloudflare-pages[bot] commented 2 years ago

Deploying with Cloudflare Pages

Latest commit:	`d6bc824`
Status:	✅ Deploy successful!
Preview URL:	https://e4d7afbb.iles.pages.dev
Branch Preview URL:	https://fix-windows-compat.iles.pages.dev

View logs