ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.07k stars 31 forks source link

fix: vendor chunk categorization #173

Closed codepunkt closed 2 years ago

codepunkt commented 2 years ago

when your product includes a . in the directory name, for example codepunkt.de, chunk matching for vendor modules doesn't work properly due to the module id being split at . and reading the second element of the resulting array, meaning to read the file extension, but instead reading an arbitrary part of the path after the . in the project (and/or other directory) name.

this fixes that by using lastIndexOf to correctly asses the extension.

Description 📖

This pull request fixes a bug

Background 📜

This was happening because finding out the extension when calculating the vendor chunks wasn't done properly

The Fix 🔨

By changing to lastIndexOf, this works.

Screenshots 📷

nx-cloud[bot] commented 2 years ago

Nx Cloud Report

CI is running for commit c47af51a3911dfd262e8ebdbd8de006c63f55173.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

ElMassimo commented 2 years ago

Thanks Christoph!