ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.07k stars 31 forks source link

chore: strict glob pattern in internal scripts #200

Closed kecrily closed 1 year ago

kecrily commented 1 year ago

Description 📖

Use the stricter glob pattern wrapped in single quotes.

Background 📜

When people use pnpm's shell-emulator, shell will not recognize a glob pattern that is not strict enough.

Because it will be processed by the shell-emulator first.

~/Desktop/iles chore/pnpm
❯ pnpm dev

> root@ dev /Users/kecrily/Desktop/iles
> pnpm -r --parallel --filter ./packages/** run dev

 ELIFECYCLE  Command failed with exit code -7.
nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0174f6c55aa51416bea58106fd39881167e73b4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets - [`nx run-many --target=build --all --exclude docs --exclude vue-blog`](https://cloud.nx.app/runs/X6RyecJkgQ) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/YOVdRx0LRm) - [`nx run-many --target=build --all --exclude docs --exclude vue-blog`](https://cloud.nx.app/runs/mYZoecD4Om)

Sent with 💌 from NxCloud.

ElMassimo commented 1 year ago

Thanks!