ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.08k stars 32 forks source link

fix: prevent heading slugs from being "app" #218

Closed ouuan closed 1 year ago

ouuan commented 1 year ago

Description 📖

This pull request prevents heading slugs from being "app".

Background 📜

If the slug of a heading is "app", it will conflict with the id of the main <div>.

Another possible fix is to use a different id for the main <div>, which is less likely to be a heading, but that could possibly be a breaking change.

The Fix 🔨

By adding "app" in the initial counter for heading slugs.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d857f505396b33443d4c0442000a9ce7023690b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets - [`nx run-many --target=build --all --exclude docs --exclude vue-blog`](https://cloud.nx.app/runs/7s1xgqsRMv) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/dsla4ZYgc4) - [`nx run-many --target=build --all --exclude docs --exclude vue-blog`](https://cloud.nx.app/runs/mlUT9Je9xQ)

Sent with 💌 from NxCloud.