Markdown HMR sometimes does not work - Githubissues

ElMassimo / iles

🏝 The joyful site generator

https://iles.pages.dev

MIT License

1.06k stars 31 forks source link

Markdown HMR sometimes does not work #232

Open ouuan opened 1 year ago

ouuan commented 1 year ago

[x] I have read the troubleshooting section before opening an issue.
[x] I have tried upgrading iles and vite.

Description 📖

When the Markdown <slot> is after some kind (I'm not sure which) of island, its HMR does not work.

Reproduction 🐞

https://github.com/ouuan/iles-issue-232-reproduction

Run pnpm dev and edit src/pages/index.mdx, only the random number changes, and the Markdown content does not change.

If the island and the <slot> are in a reversed order, or client:load is removed, or the prop is a fixed number, the HMR will work.

The real issue is that the HMR in my blog does not work after https://github.com/ouuan/iles-blog/commit/863909c49d4b0948ddc894ade4e2bdb2019fd74d, and I managed to get the above minimal reproduction.

ElMassimo commented 1 year ago

Thanks for the report, I'll try to look into it when I have some time.