ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.08k stars 31 forks source link

feat: use internal not found page during development as it's more helpful #64

Closed ElMassimo closed 2 years ago

ElMassimo commented 2 years ago

Description 📖

This pull request makes the internal not found page the default in development instead of showing a user-provided 404.

Background 📜

Previously, the internal not found page was only used if the user did not provide a 404 page, simulating the behavior of the deployed site (most service providers will use /404.html if available).

In practice, it's more helpful to see an explicit message when this happens in development, the user-provided 404 can be tested by navigating to it directly instead.

Screenshots 📷

Screen Shot 2021-12-27 at 17 24 51
netlify[bot] commented 2 years ago

✔️ Deploy Preview for iles-docs canceled.

🔨 Explore the source changes: 90b07b44bdc657ec3e4865f35eecac35c010e41a

🔍 Inspect the deploy log: https://app.netlify.com/sites/iles-docs/deploys/61ca2762f85da80009391500

netlify[bot] commented 2 years ago

✔️ Deploy Preview for the-vue-point-with-iles canceled.

🔨 Explore the source changes: 90b07b44bdc657ec3e4865f35eecac35c010e41a

🔍 Inspect the deploy log: https://app.netlify.com/sites/the-vue-point-with-iles/deploys/61ca2762eea2d30007cf0241

cloudflare-pages[bot] commented 2 years ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecfdeee
Status: ✅  Deploy successful!
Preview URL: https://adc46cef.iles.pages.dev

View logs