search

ElMassimo / iles

🏝 The joyful site generator
https://iles.pages.dev
MIT License
1.08k stars 31 forks source link

Fix type for siteUrl config option #79

Closed iainsimmons closed 2 years ago

iainsimmons commented 2 years ago

Description 📖

This pull request fixes the type shown in the docs for the siteUrl config option.

Background 📜

This was happening because the siteUrl config option seemed to have the type from the jsx option.

The Fix 🔨

By changing type to string and removing the default, it matches the actual type: https://github.com/ElMassimo/iles/blob/main/packages/iles/types/shared.d.ts#L201

ElMassimo commented 2 years ago

Thanks Iain!

iainsimmons commented 2 years ago

You're very welcome @ElMassimo ! This is a great project/framework/library and I'm keen to give it a try.