search

ElMassimo / jekyll-vite

⚡️🩸 Use Vite.js in Jekyll as your assets pipeline
https://jekyll-vite.netlify.app/
MIT License
50 stars 6 forks source link

fix: Liquid Exception: missing keyword: :ssr #9

Closed matmorel closed 2 years ago

matmorel commented 2 years ago

Description 📖

At least in ruby 3.1.0, the demo is broken with this error :

Liquid Exception: missing keyword: :ssr in /home/matmorel/jekyll-vite/docs/_layouts/default.html
bundler: failed to load command: jekyll (/home/matmorel/.asdf/installs/ruby/3.1.0/bin/jekyll)

Background 📜

That's because last_build_path must receive the :ssr option, based on last_build_metadata I assumed that the option must be false.

The Fix 🔨

I added ssr: false to last_build_path call from the last_build_metadata_path method in the lib/jekyll/vite/tags.rb file.

netlify[bot] commented 2 years ago

Deploy Preview for jekyll-vite canceled.

Name Link
Latest commit 07c8c49a53c25bbc0d9a2d851130b8f0ca143530
Latest deploy log https://app.netlify.com/sites/jekyll-vite/deploys/62dd15e7dffc3a00086c156e
ElMassimo commented 2 years ago

Thanks!

Didn't realize that I was using this internal API in jekyll-vite when I added SSR support in: