search

ElMassimo / vite_ruby

⚡️ Vite.js in Ruby, bringing joy to your JavaScript experience
https://vite-ruby.netlify.app/
MIT License
1.32k stars 122 forks source link

Install node modules for engine when starting vite container for the Rails example #368

Closed DimaSamodurov closed 1 year ago

DimaSamodurov commented 1 year ago

Description 📖

This pull request fixes error visiting /admin path 'ViteRuby::MissingExecutableError in Administrator::Timer#index'

Background 📜

This was happening because vite binary was not available for the engine (engine uses separate node_modules folder).

The Fix 🔨

By running 'yarn install' within the engine's folder when starting vite container.

Screenshots 📷

image

ElMassimo commented 1 year ago

Thanks!