search

ElMassimo / vite_ruby

⚡️ Vite.js in Ruby, bringing joy to your JavaScript experience
https://vite-ruby.netlify.app/
MIT License
1.28k stars 117 forks source link

fix: use correct dirname for manifest #458

Closed josephnle closed 4 months ago

josephnle commented 4 months ago

Description 📖

Uses path.dirname instead of path.basename so we correctly determine the manifestDir in the assets-manifest plugin.

Background 📜

This was happening because the package was using path.basename, which gives the file name and not the directory name.

The Fix 🔨

Change path.basename to path.dirname

Screenshots 📷

N/A

ElMassimo commented 4 months ago

Thanks Joseph!