When the vite_ruby document is translated into Chinese using Google Chrome's translation tool, the text style in the navigation bar is abnormal.

ElMassimo / vitepress-theme

VitePress theme for Vite Ruby

MIT License

5 stars 1 forks source link

When the vite_ruby document is translated into Chinese using Google Chrome's translation tool, the text style in the navigation bar is abnormal. #1

Closed declanchiu closed 2 years ago

declanchiu commented 2 years ago

[x ] I have tried upgrading by running bundle update vite_ruby.
[x ] I have read the troubleshooting section before opening an issue.

Description 📖

Provide a clear and concise description of what the bug is.

ElMassimo commented 2 years ago

Thanks for reporting!

Would you check if the same occurs when translating this documentation?

declanchiu commented 2 years ago

@ElMassimo

Oh, I got your point, you think it's vitepress that's causing the problem, but I'm sorry I didn't find the same problem at vuejs.org.

ElMassimo commented 2 years ago

Gotcha, seems like this was fixed here:

https://github.com/vuejs/theme/issues/56

Pull requests to apply this fix are welcome!

dboooo commented 2 years ago

https://github.com/vuejs/theme/issues/56 only solved the bug in vuejs/theme so that the problem occurs in vitepress. just wait for them merge this pr and release a new version.😃

declanchiu commented 2 years ago

@dboooo OK ! Thanks guys. 😊

brc-dd commented 2 years ago

@dboooo This is a totally custom theme. Even if we fix this in VitePress' default theme, it still would need to fixed here separately.

dboooo commented 2 years ago

@brc-dd oooo I totally didn't notice that, we should fixed it spearately!!

declanchiu commented 2 years ago

@brc-ddoooo 我完全没有注意到，我们应该单独修复它！

So you're going to submit a pr to fix it?

dboooo commented 2 years ago

@PlayGuitar-CoderQ ok :)

ElMassimo commented 2 years ago

Fixed by #2 and deployed, thanks! 😃