ElPumpo / TinyNvidiaUpdateChecker

Open sourced tool for keeping NVIDIA GPUs updated, featuring fully customizable driver installs for complete control, multi-GPU support, and more!
GNU General Public License v3.0
1.41k stars 56 forks source link

eGPUs identifiy as notebook #182

Open jwatel1 opened 1 year ago

jwatel1 commented 1 year ago

Hi, looks like the program is getting confused when I'm trying to use it to update my eGPU drivers. I'm using an RTX 3060Ti in a Razer core X Chroma connected via Thunderbolt 3 to my laptop.

Here's the output I'm getting:

TinyNvidiaUpdateChecker v1.16.5

Arg: --debug

configFile: C:\Users\jules\AppData\Local\Hawaii_Beach\TinyNvidiaUpdateChecker\app.config
CHECK_UPDATE: true
MINIMAL_INSTALL: true
DOWNLOAD_LOCATION: fr

Verifying internet connection . . . OK!

Searching for Updates . . . OK!
offlineVer: 1.16.5
onlineVer:  1.16.5

Retrieving GPU information . . . ERROR!
GPU metadata for your card does not exist! Please file an issue on GitHub and include the following information:

gpuName:    GeForce RTX 3060 Ti
isNotebook: True

Press any key to exit...

Thanks!

ElPumpo commented 1 year ago

Hi and first thanks for the bug report.

Correct TNUC does currently not support eGPUs and neither more than one NVIDIA GPU.

TNUC uses code to determine if your computer is a laptop or desktop no matter if the GPU accually is.. not sure how to solve it without some special command line argument

ElPumpo commented 1 year ago

[..] I don't know if there's a way to identify if a GPU is an "eGPU". If there is no way then the only solution I see is using command line arguments, like other projects have used in the past.

I belive the inital fix would be to provide a command line argument overriding notebook/desktop identify code. I'll keep this issue open until automatic solution can be implemented.

I'll start development on the workaround.

ElPumpo commented 1 year ago

v1.17.0 has been released with the following new command line arguments:

ElPumpo commented 3 months ago

Perhaps a check box in the new GPU selector "Override desktop/notebook identification"

ElPumpo commented 2 months ago

J I wish not to close this issue until a better solution then arguments are added

ElPumpo commented 2 months ago

Animation

ElPumpo commented 2 months ago

Now I need code that saves the overriden settings for the GPU because we use Chassies Type only currently.. it's not ideal

ElPumpo commented 2 months ago

Accually that idea was scapped, and the referenced commit has a fix for this which is very simple. Just invert the notebook check if no Gpu Id is found for that type. Having a override Gpu Type code was too complex for no good reason.

I have pushed the code to branch type-override maybe I'll review it in the future

Because if the GPU name exists in both Desktop and Notebook, then we still need a proper override like the GIF shows, and the referenced commit wont fix that issue