search

ElPumpo / TinyNvidiaUpdateChecker

Open sourced tool for keeping NVIDIA GPUs updated, featuring fully customizable driver installs for complete control, multi-GPU support, and more!
GNU General Public License v3.0
1.41k stars 56 forks source link

Implement `--noprompt` command line argument to disable "Press any key to exit..." prompt #189

Closed TomKranenburg closed 1 year ago

TomKranenburg commented 1 year ago

added --noprompt command line argument to disable "Press any key to exit..." prompt

TomKranenburg commented 1 year ago

Ahhh. I think that might be notepad++ messing things up actually. It will probably be converting the line endings and it got in somehow.

I did think it was a lot of copy pasted code. But I wanted to try stick to something that was close to what you already had.

One moment I'll add it in. Totally fair choices.

TomKranenburg commented 1 year ago

Ok I've added it in. It ended up being Visual Studio 2022 that was helping us to death by automatically mangling our white space and line endings. Really annoying. Just want to clarify that it wasn't Notepad++ messing up.

The code is a lot cleaner now with the callExit function I agree.

TomKranenburg commented 1 year ago

Done.

ElPumpo commented 1 year ago

Now finally you have not added your changes to the changelog CHANGELOG.md

image

Instead of Fixed it's Added

Write the following, or similar

--noprompt command line argument disabling exit prompt (author: TomKranenburg). See issue #188

TomKranenburg commented 1 year ago

Added @ElPumpo

ElPumpo commented 1 year ago

You're using the ` char wrong. Don't use it twice just once per side

TomKranenburg commented 1 year ago

Done

ElPumpo commented 1 year ago

You were to use [Unreleased], not to release a new version 😄

Thanks for your contribuations to the project!