search

ElPumpo / TinyNvidiaUpdateChecker

Open sourced tool for keeping NVIDIA GPUs updated, featuring fully customizable driver installs for complete control, multi-GPU support, and more!
GNU General Public License v3.0
1.41k stars 56 forks source link

Add --dry-run parameter #192

Closed TomKranenburg closed 3 months ago

TomKranenburg commented 1 year ago

Bothering you again so soon @ElPumpo (:

Let me know how you feel about this one. I have a better idea of your workflow now so this one should be a little easier. Hopefully.

I'm adding the --justcheck parameter that just checks for updates to both the app and the system GPU drivers. No download or installation is carried out.

This allows the application to fit nicely into larger ecosystems.

ElPumpo commented 1 year ago

Hi Tom you never bother me! I want all the help you can throw at the project, really!

The command line argument name is just off. Come up with something better.

Aand again you're missing the changelog

TomKranenburg commented 1 year ago

Wait and see if you want to add it before I add the changelog.

What do you think for the argument name? Just pick what you like I'm not fussed. Although I might rename the variable as well so it's more intuitive.

ElPumpo commented 1 year ago

Nah you can add the changes yourself 👓

And yes the variable name aswell it's so confusing haha

TomKranenburg commented 1 year ago

I will add the changes but really you can pick it. I'm not fussed. What about "--checkupdate"?

Back at the day job now but I'll knock this out when I get home. These two parameters are really useful for building TNUC into larger scripts.

ElPumpo commented 1 year ago

Hi. I think you need more time for this argument name 😂

TomKranenburg commented 1 year ago

Can literally be anything. Go wild.

ElPumpo commented 12 months ago

Have you come up with a new name yet?

TomKranenburg commented 12 months ago

No. Please just pick one you're comfortable with.

DetermineAbsurd commented 5 months ago

--dryrun or --dry-run is pretty standard in name among different applications for this type of function.

ElPumpo commented 5 months ago

Yea that seems to be the industry standard. @TomKranenburg if you fix it I will merge PR. Thanks

TomKranenburg commented 3 months ago

Done.

Let me know how you feel about it.

ElPumpo commented 3 months ago

Tom I'm not going to lie to you that commit was super low effort you didn't even change the variable name to match and there's indenting errors everywhere.. whatever it's fixed now and will be merged and added to the next release. Thank you for your contributions to this project!

TomKranenburg commented 3 months ago

I can change it if you want. I am work writing code full time.

It is a very small commit. I have to agree.