ElPumpo / TinyNvidiaUpdateChecker

Open sourced tool for keeping NVIDIA GPUs updated, featuring fully customizable driver installs for complete control, multi-GPU support, and more!
GNU General Public License v3.0
1.53k stars 58 forks source link

Optimize gpu-data.json and os-data.json fetching #195

Closed wangcheng closed 5 months ago

wangcheng commented 1 year ago

Currently TNUC will fetch the latest gpu-data.json and os-data.json every time, which is not ideal for the following reasons:

My proposed solution:

ElPumpo commented 1 year ago

Hi Wang. Thanks for enlightning me about this, I agree it should be cached in the configuration directory.

You could also compare the date of the cached files so if they are a week old then update them.

Great idea! I will implement this for the next release.

wangcheng commented 1 year ago

Thanks for the reply!

Please consider implementing reading files from AppData folder. I will appreciated it as a user in China and I don't like the idea of put some json files in my home directory. Thanks!

ElPumpo commented 5 months ago

Hi sorry for the extreme delay, this feature has now been developed and will be released in the v1.18.0 update. Thank you for your feedback, indeed the implementation was very bad.

wangcheng commented 5 months ago

Thank you so much!