ElPumpo / TinyNvidiaUpdateChecker

Open sourced tool for keeping NVIDIA GPUs updated, featuring fully customizable driver installs for complete control, multi-GPU support, and more!
GNU General Public License v3.0
1.41k stars 56 forks source link

WinRAR error: Unknown option "optemp" (Update WinRAR to fix) #233

Closed H3X1C closed 1 month ago

H3X1C commented 1 month ago

Hi,

I have WinRAR set as my default archive program. It seems recently the command line parameters have been changed and now get this error when it attempts to unpack: image

Command line arguments: image

ElPumpo commented 1 month ago

Hi man, thanks for the bug report. I will investigate this ASAP!

ElPumpo commented 1 month ago

Interesting, I cannot reproduce this issue, @H3X1C what's your WinRAR version?

H3X1C commented 1 month ago

WinRAR 5.71, I know an older version. Checking I don't think this version supports the optemp arg. I see you recently refactored the process spawning logic: https://github.com/ElPumpo/TinyNvidiaUpdateChecker/blob/ce6e311466d36c4632170b356d1db77ef8b55467/TinyNvidiaUpdateChecker/MainConsole.cs#L902 This would explain why it previously worked and now doesn't for my version.

H3X1C commented 1 month ago

Guessing the aim is extraction to a folder called temp overriding existing files. If so the following works on my version: "c:\Program Files\WinRAR\WinRAR.exe" x HardwareManagerSvc.zip -o+temp

Was the p in -optemp a typo?

Technetium1 commented 1 month ago

@H3X1C be wary of versions before 6.23 https://nvd.nist.gov/vuln/detail/CVE-2023-38831

ElPumpo commented 1 month ago

Yea update WinRAR, that will fix the problem, seems like that old version doesn't have this CLI argument. I agree with you it looks very weird, but apparently that's how they developed it. If I were them I would have something like a = char to sepeate arg and its value.

This is new code because we now extract the full driver file and then query all components, display to user which chooses which ones he wants.

Also like Mr Tech is advising you.. update! It has a CVE

kirin6666 commented 1 month ago

Just wanted to say thanks for the resolve, I was having the same issue and have thus resolved it after reading this!

ElPumpo commented 1 month ago

Perhaps if this secondary argument works on both version I might change it

EDIT Yea i dont think i am going to address this issue. Just update winrar

H3X1C commented 1 month ago

Thanks guys, I've swapped over to 7zip so problem solved