search

ElSnoMan / pyleniumio

Bring the best of Selenium and Cypress into a single Python package
https://docs.pylenium.io
MIT License
267 stars 50 forks source link

fix package webdriver-manager version #316

Closed IgBuS closed 1 year ago

ElSnoMan commented 1 year ago

@IgBuS Thanks for submitting a PR! I'll approve it so a CI pipeline runs, but if the only change was pinning webdriver_manager, then that tells me their latest version is the problem. Very interesting

ElSnoMan commented 1 year ago

NOTE: Another PR is changing webdriver-manager as well. I'm not sure which version and constraints we should be using: https://github.com/ElSnoMan/pyleniumio/pull/310

LostInDarkMath commented 1 year ago

@IgBuS Thanks for submitting a PR! I'll approve it so a CI pipeline runs, but if the only change was pinning webdriver_manager, then that tells me their latest version is the problem. Very interesting

As I said in https://github.com/ElSnoMan/pyleniumio/pull/310#issuecomment-1649458532: The new version of webdriver-manager contains breaking changes.

ElSnoMan commented 1 year ago

I'm gonna close out this PR since I created this one which replaces webdriver-manager with Selenium Manager: https://github.com/ElSnoMan/pyleniumio/pull/317