Pin blinker to version <1.8 as fix for #329.

ElSnoMan / pyleniumio

Bring the best of Selenium and Cypress into a single Python package

https://docs.pylenium.io

MIT License

270 stars 50 forks source link

Pin blinker to version <1.8 as fix for #329. #330

Closed mpibpc-mroose closed 5 months ago

mpibpc-mroose commented 6 months ago

As PyleniumIO relies on selenium-wire (which is no longer alive/maintained) and this project again uses blinker one would like to pin this "stack" to a working version.

selenium-wirein it's final version uses a private method of blinker which has been removed in the 1.8 release. As selenium-wire cannot be changed the only way is to pin blinker.

ElSnoMan commented 6 months ago

You've raised really good points! It's probably best to remove selenium-wire as a dependency. If someone wants to add similar functionality, they are welcome to!

LostInDarkMath commented 5 months ago

Yes I agree. Removing the selenium-wire dependency would be the cleanest solution.

ElSnoMan commented 5 months ago

I'm closing this as we've now removed selenium-wire completely. This will be out in v1.21