ElTyranos / CommunityFlavorPack

Historical portrait accessories for Crusader Kings 3 characters.
https://communityflavorpack.com/
16 stars 7 forks source link

The new bonnets are not used? #73

Closed voy178 closed 3 years ago

voy178 commented 3 years ago

I have yet to see any Iberian lady wear the low and high nobility bonnets. Males do but rarely. Common bonnets appear somewhat frequently for both males and females.

Is it possible that they're bugged or not implemented properly?

ElTyranos commented 3 years ago

What is your game current date ? if you're in 1066 (right after game start), there are no iberian duchies but Portugal. On top of that, most counties are held by the kings as they are only a few. The hats should start to appear when your game will have more duchies and counties held by Iberians.

voy178 commented 3 years ago

Ca 1300. I've played the game throughout from start with your mod as Castille while preserving the other traditional Iberian kingdoms including Portugal with different Iberian cultured vassals of all ranks. (I theme my playthroughs after your updates to appreciate them <3)

Most wear nothing if they're counts. Some male dukes do wear the bonnet but rarely. Their spouses prefer other headgear like crowns. Also you're forgetting about Barcelona, who's duke do wear the bonnet sometimes, but their wives do not.

ElTyranos commented 3 years ago

Could you please, with character browser and "iberian culture" filter, send me pics of your Iberian characters ordered by rank so I can have a estimation of the ratios ?

Or simply send me your savegame so I can use it myself to tweak the attribution ratios.

voy178 commented 3 years ago

I didn't take a pic of everything, it's too much but as you can see, only male dukes wear bonnets sometimes but more often crowns, and only unlanded or married to unlanded females wear the bonnet of the common variant. Mayors wear common bonnets the most. Trust me, I've checked everything, they're just not there.

20210118142847_1 20210118142850_1 20210118142853_1 20210118142856_1 20210118142900_1 20210118142903_1 20210118142906_1 20210118142915_1 20210118142918_1 20210118142950_1 20210118142954_1 20210118142957_1 20210118143000_1 20210118143003_1 20210118143006_1 20210118143008_1 20210118143011_1 20210118143013_1 20210118143015_1 20210118143027_1 20210118143029_1 20210118143031_1 20210118143033_1 20210118142824_1 20210118142829_1 20210118142840_1 20210118142844_1

ElTyranos commented 3 years ago

Can you please send me your savegame (from Documents\Paradox Interactive\Crusader Kings III\save games) ?

voy178 commented 3 years ago

Not possible, too large for GitHub. But it's not like you can't replicate it. If you see but one low or high bonnet for females, you can debunk this as a problem with my game.

ElTyranos commented 3 years ago

01_headgear.txt

Could you please try with these parameters in your current game ? I had to cheat to reproduce a full iberian spain, I'm not sure the result is consistent with a regular game.

Just overwrite this file in \steamapps\workshop\content\1158310\2220098919\gfx\portraits\portrait_modifiers

voy178 commented 3 years ago

Well it had an affect. A handful of characters now wear bonnets, mostly spouses, but the vast majority still prefer crowns, trait/skill specific clothing, veils/wimples/barbettes or mostly nothing. Also, the Iberian grandmasters wear the bonnet too sometimes which doesn't go well with the tabard, but what to do.

So I tried a new game to see if that would help more. Cheated my way to more land, landed Castilian Christian adults and waited until most got married. The result was that many more dukes wore the bonnets which was nice to see, so did their duchesses, although it's kind of weird to see the mishmash of crown/bonnet couples. The counts continued to wear nothing, but their spouses certainly wore more bonnets, but not the majority, I also saw one countess wearing the common bonnet which must have been a mistake and a rarity at that. So really, it was a success apart from the hatless counts. I would keep the high probability of wearing bonnets though, makes them stand out from the Western Europe crowd. Here's a save file.

githubtestiberia.zip

20210119152652_1 20210119152659_1 20210119152704_1 20210119152708_1 20210119152712_1 20210119152716_1 20210119152720_1 20210119152345_1

ElTyranos commented 3 years ago

Ok the issue is that I copy paster "western_low_nobles" which has a typo. None of the western counts had a hat either so it bugged me. Checked the code aaaaand... Well done PDX.

Fixing all this.

ElTyranos commented 3 years ago

Regarding the mismatch between spouses, there's nothing I can do, the probability is computed per character, I have no way to check if spouse wears an iberian hat or not.

voy178 commented 3 years ago

Glad to have been of help...? I completely understand the limitations, I'm just reporting what I see.

ElTyranos commented 3 years ago

I did the report to paradox aswell, but CFP will have the fix while they update : https://forum.paradoxplaza.com/forum/threads/ck-iii-01_headgear-txt-typo.1452988/

I'll also try to fix the helmets assigned to characters who are not at war.

voy178 commented 3 years ago

I tried your fix and indeed they were stuff now which is such a relief and looks much better... however, I think this revealed even more potential bugs, I still don't see any low noble bonnets for the males, but they'll come around I guess. Regardless, thanks for fixing it!

ElTyranos commented 3 years ago

The fix on PDX forum is for vanilla code, I also fixed CFP categories and they will all work in the hotfix. Thank you for your inputs !