search

ElWanderer / kOS_scripts

kOS scripts and libraries
28 stars 8 forks source link

Automated science collection - hangs when experiements can't be run #157

Closed ElWanderer closed 4 years ago

ElWanderer commented 4 years ago

If you try to collect science from an accelerometer in orbit, the game will tell you it can't be run. The automated waypoint science script doesn't know this, so it hangs (I presume because it is waiting for the science part to become full of data, which will never happen).

ElWanderer commented 4 years ago

I've made a change to give science experiments a 15-second timeout. Also, all experiments are deployed immediately if possible - the wait for data takes place afterwards. This means looping through the experiments twice, but should ensure we run everything at closest approach (or as near as we can).

There might still be a delay if an experiement has data and needs to be reset first, but that wouldn't typically happen with the automated collection.