search

ElaWorkshop / TagListView

Simple and highly customizable iOS tag list view, in Swift.
MIT License
2.64k stars 492 forks source link

Update TagListView to support max number of displayable rows #106

Closed TosinAF closed 7 years ago

TosinAF commented 7 years ago

Adding support for a max number of displayable rows. Default is 0, which like in UILabel means infinite.

aleene commented 7 years ago

Not sure this should be done in TagListView. You can set the height of your TagListView in the storyboard and thus limit the number of rows? And what should happen if the number of tags exceed the maximum number of rows?

TosinAF commented 7 years ago

@aleene similar to setting a max height, it would cut off and now you wouldn't need to calculate what height equals to two rows. Fine to close it. Im using a fork, just thought it might be a good addition to the main repo.

anti-transmission commented 7 years ago

I think the pr was not completed? If number of rows is larger than displayableRows, the extra tags would not show at all.