ElaWorkshop / TagListView

Simple and highly customizable iOS tag list view, in Swift.
MIT License
2.64k stars 493 forks source link

Add multiple selection property, add function setTags(_ tags: [String]) #119

Open EvsenevDev opened 7 years ago

EvsenevDev commented 7 years ago

I'm added property for multiply selection and function setTags(_ tags: [String]) And for better UX i'm changed longTap to simple tap for selection.

EvsenevDev commented 7 years ago

@Cee I'm wrote about it. I change default selection action from long press to simple tap for better UX. But long press action possible to set if needed. It's just default settings. About selected state it's be work if TagsView has selection color. What you think about it? But i can return back Long Press and setup default selection color if needed.

Cee commented 7 years ago

@EvsenevDev I've tried to run your code and found these problems I mentioned before.

ethanfox commented 7 years ago

How did you fix the tag selection issue???

EvsenevDev commented 7 years ago

Selection was on long press, now it's simple tap.

Sadmansamee commented 7 years ago

waiting for the merging

EvsenevDev commented 7 years ago

@Sadmansamee Did you use my fork? All works fine?

isurukej commented 7 years ago

Hi ,

Thanks for doing this project.

There is an issue when tag length is longer then view length. I think, I fixed that issue. I will commit my changes later.

On Thu, Nov 9, 2017 at 2:00 AM, Bogdan Evsenev notifications@github.com wrote:

@Sadmansamee https://github.com/sadmansamee Did you use my fork? All works fine?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ElaWorkshop/TagListView/pull/119#issuecomment-342949484, or mute the thread https://github.com/notifications/unsubscribe-auth/AAep3JnJV4-Eh3b3sHdMmJGc9MHsanybks5s0g9hgaJpZM4NL8aV .

-- regards, Isuru.

EvsenevDev commented 6 years ago

@syedrazackimran it's not merged and don't know why :)

EvsenevDev commented 6 years ago

@Cee @anti-transmission @ethanfox Updated :)

CoderEmb commented 3 years ago

Can this please be merged? I am looking for multi-selection functionality and selection on single tap.