[🐛 BUG] - Lines showing as 5X and 6X don't have formatting/color

[fmr-iv]

Describe the bug 5X and 6X lines are displaying without any green background coloring

To Reproduce Run the module for station ID 397 (uptown and downtown) and it should appear

Expected behavior 5X and 6X lines should have the green color/format behind them. Ideally these would just say 5 or 6 and have a green square background to indicate express lines

Actual behavior 5X and 6X lines do not have the green color/format behind them

Screenshots

Platform (please complete the following information):

• Node Version:
• Web Browser/Electron version:
• Hardware [e.g. Raspberry Pi 2/3, Windows, Mac, Linux, System V UNIX]:

Configuration What does the used config.js file look like? Don't forget to remove any sensitive information!

Additional context Add any other context about the problem here.

[Elaniobro]

@frankrende; thank you for submitting this issue. I am unfamiliar with 5x & 6x lines... are these just Green line but express?

What is the expectation here. Can you link me to what the actual logo should look like? Thanks!

[fmr-iv]

Hi @Elaniobro -

That's correct, they're express trains for the 5 and 6 lines. If you look at the MTA Subway map, you can see some 5/6 trains are green-squares instead of green-circles. This indicates that they're express stops.

4 also has an express line, but I failed to mention it in my OP since it wasn't appearing at the time.

The trains themselves and most other apps indicate an express train with a diamond icon:

Would it be possible to display these still as 4/5/6, but have a green diamond behind them instead of a green circle?

-Frank

[Elaniobro]

@frankrende; thanks for the screenshot. I am unable to pull up an express train. Is there a specific time of day they run? I'll debug then.

[fmr-iv]

Hey @Elaniobro -

I'm still seeing some uptown 5x and 6x trains from station 397 as of right now.

From a quick google search, there's a lot of conflicting information relating to these lines. Some indicate that it's "rush hour" service and is only available at certain times (see here). I also found some MTA maps that show the same "diamond" logo for additional lines, like the 7.

This Wiki article for the 4 line shows the diamond logo as an indicator for rush hour routes.

Let me know if you need more information!

[Elaniobro]

Dang, I am only seeing 5/6 right now, and not 5x/6

x

[fmr-iv]

Can you try the uptown direction? That’s where I’m seeing them

On Fri, Feb 11, 2022 at 5:47 PM Elan Trybuch @.***> wrote:

Dang, I am only seeing 5/6 right now, and not 5x/6 [image: Screen Shot 2022-02-11 at 17 45 37] https://user-images.githubusercontent.com/710847/153680964-079d2096-c48c-4e5c-aae3-b95a79892710.png x

— Reply to this email directly, view it on GitHub https://github.com/Elaniobro/MMM-nyc-transit/issues/72#issuecomment-1036705996, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA6FQ52V323TG6CIBYXELDU2WGWLANCNFSM5OCL45XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from my iPhone

[Elaniobro]

@frankrende would you mind verifying the fix on the GIT-72-express-trains branch? I think I got it, but need additional QA support.

[fmr-iv]

Sure, I can check it out tomorrow morning. Thanks for the quick response!

On Fri, Feb 11, 2022 at 9:15 PM Elan Trybuch @.***> wrote:

@frankrende https://github.com/frankrende would you mind verifying the fix on the GIT-72-express-trains branch? I think I got it, but need additional QA support.

— Reply to this email directly, view it on GitHub https://github.com/Elaniobro/MMM-nyc-transit/issues/72#issuecomment-1036948242, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA6FQ7PLGZ4MGLAGQMNZ3DU2W7D5ANCNFSM5OCL45XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from my iPhone

[fmr-iv]

Hey @Elaniobro -

I just loaded your branch, but unfortunately I can't find any express trains at the moment. I'll check again later today.

But overall everything else is still working as expected! One thing I noticed from your screenshot is the diamond seems to be off-center compared to the circle logos above it (and the "6" inside the diamond doesn't seem to be centered). Is that something that can be adjusted?

Besides that I'll try to give more testing feedback once I get a working example. Thanks for your help!

-Frank

[fmr-iv]

Hi @Elaniobro - I just tested and can see the new icon for the express 6 train. The only feedback I have is what I expressed in my previous comment:

• [x] The line number doesn't appear to be centered inside the logo
• [x] The logo itself seems off-centered compared to the other logos. It's also a bit smaller maybe?

-Frank

[Elaniobro]

@frankrende ~would you mind sharing a screenshot? Thanks~

Will you please pulldown the latest on that branch? Should be good now.

[fmr-iv]

Hey @Elaniobro

Thanks for the update! The "6" now appears centered within the green diamond. However it still appears to be smaller than the regular lines (both in font size and diamond size). It's not a big deal though, so I'm find with this change if it's too complicated to adjust!

[Elaniobro]

@frankrende glad to see its working. Yes, that is by design. Any bigger and the spacing becomes problematic between the lines.