search

Elaniobro / MMM-nyc-transit

MTA transit module for Magic Mirror
MIT License
21 stars 14 forks source link

Slowing the entire Mirror down #85

Open Nneuland opened 2 years ago

Nneuland commented 2 years ago

After going through all of the possibilities to what was slowing my mirror. Turns out it was this module. I had to disable the module in the config file to fix.

Essentially, upon restarting of the mirror with this module active, the mirror's refresh rate would be fine, but slower and slower over time. This was most evident with the clock module (seconds refreshing after 2 seconds, then 5, 10, ect)

Have I done something to allow this to happen?

Elaniobro commented 1 year ago

Probably the walking time countdown. I added it in, with haste. I probably need to do garbage collection and remove the timer from memory.

Elaniobro commented 1 year ago

@Nneuland; did you ever dig into this and remove the timer code? Another possible issue is the fact its using ECMA5; and not modern js. This was done so with purpose to support pi0w;

I suppose it might be time to modernize this with modern language.

Nneuland commented 1 year ago

TBH, I currently have the module disabled. I have not looked into it any further. But would love to be able to use it without negatively influencing the other modules.

On Sun, Feb 19, 2023 at 9:13 AM Elan Trybuch @.***> wrote:

@Nneuland https://github.com/Nneuland; did you ever dig into this and remove the timer code? Another possible issue is the fact its using ECMA5; and not modern js. This was done so with purpose to support pi0w;

I suppose it might be time to modernize this with modern language.

— Reply to this email directly, view it on GitHub https://github.com/Elaniobro/MMM-nyc-transit/issues/85#issuecomment-1436000486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV4YKP4UZ6NG6PW6LXDJLITWYITBTANCNFSM5ZMJW65Q . You are receiving this because you were mentioned.Message ID: @.***>