search

Elastic-Finance-DAO / eefi_contracts

0 stars 0 forks source link

[DLL-05C] Suboptimal Struct Declaration Style #71

Closed stalker474 closed 4 months ago

stalker474 commented 5 months ago

DLL-05C: Suboptimal Struct Declaration Style

Type Severity Location
Code Style DepositsLinkedList.sol:L37

Description:

The linked declaration style of a struct is using index-based argument initialization.

Example:

list.nodes[newNodeId] = Node(_deposit, NULL);

Recommendation:

We advise the key-value declaration format to be utilized instead, greatly increasing the legibility of the codebase.