search

Elastic-Finance-DAO / eefi_contracts

0 stars 0 forks source link

[WRE-02C] Incorrect Accuracy of Wrapper (Informational) #72

Closed stalker474 closed 6 months ago

stalker474 commented 6 months ago

WRE-02C: Incorrect Accuracy of Wrapper (Informational)

Type Severity Location
Code Style Wrapper.sol:L15

Description:

The wrapper will perform a conversion of AMPL to wAMPL using the 10_000_000e12 literal representing 10 million for a 12 decimal token, however, the actual wAMPL deployment utilizes the 10000000 * (10**18) representation indicating 10_000_000 for an 18 decimal token.

Example:

uint256 public constant MAX_WAAMPL_SUPPLY = 10_000_000e12; // 10 M at 12 decimals

Recommendation:

We advise this trait to be evaluated as it represents a discrepancy between the real-world wAMPL asset and the wAMPL asset defined by the Elastic Finance team.

stalker474 commented 6 months ago

This is intended behavior, as even though we use the denomination wAMPL, we actually want smaller amounts as stakes in the contracts and our internal wAMPL is a totally different asset