ElasticEmail / ElasticEmail.WebApiClient-js

Deprecated library. Easily send emails with Elastic Email using Web API JS Client https://elasticemail.com/
MIT License
15 stars 9 forks source link

Are there any Types (d.ts)? #3

Closed itayronen closed 6 years ago

itayronen commented 6 years ago

Hi, My startup is considering to use your service. We are using typescript and it would be amazing if you had types.

You do have a lot of comment docs, but its still confusing. For example: On Logs.Load(), the status param doc is:

So what is it? It says its an {Object}, and a list, and what does a list mean? A javascript array or a string of comma seperated numbers?

Thanks, Itay

ppodolak commented 6 years ago

@itayronen Hi, yes we are planing to create proper types for our library, for now i suggest using // @ts-ignore above import of the package. Thanks for pointing out inconsistency in the docs. The param that you are asking should be string with comma separated enums, like "2,4,5", we will try to cover this asap, in the meantime i suggest using docs from our site.

itayronen commented 6 years ago

Thank you for the quick response :) It is very important for us. One of the reasons that we wanted to give ElasticEmail a try was the fact that this repository seemed alive unlike many of the alternatives.

I got email sending down and wrote it in typescript. Maybe I'll end up uploading a package for basic usage written in typescript.

I'll close the issue for now.