Release 3.5.1 installed, but main page shows 3.5.0 installed

ElasticHQ / elasticsearch-HQ

Monitoring and Management Web Application for ElasticSearch instances and clusters.

http://www.elastichq.org

Other

4.97k stars 532 forks source link

Release 3.5.1 installed, but main page shows 3.5.0 installed #491

Closed pommetjehorlepiep closed 5 years ago

pommetjehorlepiep commented 5 years ago

General information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Alpine 3.10
ElasticHQ Version: 3.5.1
Elasticsearch Version: N/A
Python version (ignore is using docker image): 3.7.3
Browser Vendor and Version (if applicable):

Issue Description

Installed release 3.5.1 using source file (tar.gz). On the main page, it shows the installed version incorrectly as being 3.5.0

Source Code / Logs

N/A

Screenshot

royrusso commented 5 years ago

I'm not able to reproduce it. Downloading the zip from master branch outputs the correct version. Is it maybe the browser cache?

pommetjehorlepiep commented 5 years ago

Hi Roy, it is/was not the browser cache...

Installed the freshly released 3.5.2 version, and that one is showing the correct version! :)

Did some comparisons between 3.5.2 and 3.5.1 and found that the API_VERSION in 3.5.1 is set to 3.5.0. In 3.5.2 it's set correctly to 3.5.2

Compare https://github.com/ElasticHQ/elasticsearch-HQ/blob/v3.5.1/elastichq/config/settings.py vs https://github.com/ElasticHQ/elasticsearch-HQ/blob/v3.5.2/elastichq/config/settings.py

So problem is solved in latest version. Probably no need to fix 3.5.1 for this.

royrusso commented 5 years ago

Yes. I after releasing 3.5.2, I realized, I somehow, still unknown, messed up the tagging. Thanks!