search

ElcioGoes / jodconverter

Automatically exported from code.google.com/p/jodconverter
0 stars 0 forks source link

Hide internal classes from exported API #43

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Internal classes should not be defined as public.

There's no need to expose the OfficeManager implementation either.
Introduce a Builder object instead, something like

  OfficeManager officeManager = new OfficeManagerConfiguration()
    .setOfficeHome(...)
    .setPort(...)
    .buildOfficeManager();

Original issue reported on code.google.com by mirko.na...@gmail.com on 17 May 2009 at 2:03

GoogleCodeExporter commented 8 years ago

Original comment by mirko.na...@gmail.com on 17 May 2009 at 2:03

GoogleCodeExporter commented 8 years ago 
Done

Original comment by mirko.na...@gmail.com on 17 May 2009 at 7:32

GoogleCodeExporter commented 8 years ago

Original comment by mirko.na...@gmail.com on 27 Mar 2011 at 1:21