ElderDrivers / EdXposedManager

Companion Android application for EdXposed
https://edxp.meowcat.org/
GNU General Public License v3.0
1.78k stars 247 forks source link

Resource hooks not working #147

Closed Evengard closed 3 years ago

Evengard commented 3 years ago
Include the following:
Reproduction Steps
  1. Install a recent version of EdXposed
  2. The resource hooking is not working
  3. Go to the EdXposed Manager Settings and try to disable/enable the resource hooking setting
  4. Nothing happens no matter what I do (rebooting, switching the setting on or off)
Expected Result

There should be a way to enable resource hooking which was changed to be disabled by default in recent versions of EdXposed

Actual Result

There is no way to reenable resource hooking

kotori2 commented 3 years ago

I think EdXposed doesn't support resource hook from some version.

MlgmXyysd commented 3 years ago

@Evengard https://github.com/ElderDrivers/EdXposed/commit/b1bc7200a6d351d208d33336257a709877932bc2

Evengard commented 3 years ago

Yes, I found that commit, but the resource hooks actually worked well, and it seems there is no way to change this setting (or is there some other way to change it without the help of EdXposed Manager?)

MlgmXyysd commented 3 years ago

@Evengard Due to the commit, the res hook will always disabled.

Evengard commented 3 years ago

That's actually what I asked by this issue to change - to make the switch be able to switch it back on (maybe renaming it also, or add another switch) The commit changed the name of the setting and inverted its mechanic, it didn't disabled it completely forever.

MlgmXyysd commented 3 years ago

It cannot be changd

always disabled

Evengard commented 3 years ago

Is it a developer policy/strategy, that you don't want to see it implemented (even if it could be technically possible)?