Elders / VSE-FormatDocumentOnSave

Visual Studio - Format Document on Save
Apache License 2.0
117 stars 22 forks source link

VS TabToNextReference extension and Resharper #29

Open netcorefan1 opened 4 years ago

netcorefan1 commented 4 years ago

Hello, please accept my apologies for posting this here, but I have not been able to find any repo for the "TabToNextReference" extension that you published on the Marketplace.

I really like it, but unfortunately with Resharper installed it only works after disabling Structural navigation (Environment | Editor | Behaviour | Structural navigation), a feature that no one want to lose. I can't find any "TabToNextReference" command in order to set a different keystroke combination and preserve R# default behaviour.

Coderush extension also have a tab to next reference feature and it works fine with R#. Not sure how they made it to work. Thanks VS2019 16.6.1

P.S. it would also be nice if we could return to previous reference.

mynkow commented 4 years ago

Hello @netcorefan1

yeah, there is no repo for the extension. I will try to setup something soon.

Just to clarify, do you have conflict problems with the keyboard bindings or there is a behavior issue?

netcorefan1 commented 4 years ago

Thanks for your help! As far as I know there are no problems with keyboard bindings. Not sure if a key combination is the best way to deal with this (CTRL, ALT, SHIFT are already bound to VS non-editable main commands). May be a quick TAB double click (plus CTRL for previous match) could the most easy way?

mynkow commented 4 years ago

My question was if there is a key binding conflict between the extension and resharper. Like, one key bound to two extensions. A solution to this could be transforming the extension to a custom command so you could bind it to whatever key you want.

OR

the extension does not work properly when resharper is installed

netcorefan1 commented 4 years ago

I didn't noticed any sort of conflict. Even with your extension enabled, Resharper TAB navigation and default vs TAB combinations continue to work without any problem. Your extension works fine when Resharper is installed, but only with its structural navigation (based on TAB) disabled. As soon as I re-enable that feature TTNR becomes dead and don't do anything.

This is what happens in the block of code I identified as the possible source of the problem. Execution enter in the second block when SN is enabled, in the first block when SN is disabled: TabToNextReference The good news is that R# does not steal the command and your code still receive the callback.

I totally agree with you, converting to a custom command would be the best solution since should allow for easier and greater customizations. Thanks