Open IvorAmlug opened 1 year ago
Hello, although there are some recent remarks attempting to support it in Iris to support Shimmer's custom lightmaps, it's not viable and does not even work in Optifine. Side note, there's already SSGI implemented in the shader since it brings colored lighting with shadows. Although it's very noisy I am planning to better improve its quality soon in later versions.
However, I will consider your suggestion and make an attempt to implement it. If it holds viable, the feature will be kept in a form of a new setting. Otherwise, I simply cannot implement it for technical reasons. But for now I will keep this post open until I update you on the situation.
Thx for considering it. I just hope for the best then ig.
https://github.com/Low-Drag-MC/Shimmer/wiki/Shader-Compatibility.-(For-Shader-Dev) I decidet i post it here incase u missed it. They have an entry on their git now on how to do it. If its still in Considered
Considering I've been diving into modding recently, this post is still of course in consideration.
Describe the compatibility issue not a issue/bug but a Compatibility Suggestion. Basicly whenever u activate any shader the Coloured Lights of shimmer deactivate themselfs. Which is obviously Expected. But as Far as the Shimmer Github wiki note for Compatiblity goes its Possible to combine Shaders and their mod. But it has to come from the Shader itself. As noted on their wiki:"Iris/oculus: colored light is not supported when the shader is enabled usually Shader dev can choose to change their code to support this" (Optifine isnt supported at all)
-Steps to reproduce the behavior:
-Expected behavior
If u manage to add support the coloured lights should still be shown and look smth like this ![2023-02-28_22 15 23](https://user-images.githubusercontent.com/38656481/221982000-37bf881d-35ff-47ca-a639- "Note that screen was made without a shader since those Compatible are rare right now" Screenshots -If applicable, add screenshots to help explain your problem.
With Shader.
Without shader Basicly the Coloured Light dissabling itself like mentioned above
-Hardware/ModVersions
-Additional context
The Block in the Screens is a Red Corrundum Block from Quark... Glowing the Correct colour. Thats also why i think the shader might benefit from the support. Shimmer is basicly a mod Capable of adding Coloured lights to modded or Vanilla blocks, Items or Particels either via an ingame command (temporarly) or via configuratuin files in either an Extra folder or Loadet TP. Quick note: it will Obviously have impact on Perfomance if shimmer is used. And i also have no idea of how much Change to the code need to be done. Since there isnt much Information yet on their Github side (Found here btw: https://github.com/Low-Drag-MC/Shimmer/wiki). If its to much to add the support then simply Close this post. I just thought it would be worth a try to at least ask.
Best regards, Ivor